Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimulationTimeSeriesMatrix module #293

Merged

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Sep 1, 2023

Initial version - more functionality to be added.

Improved Simulation time series module for plotting multiple ensembles and vectors, with subplots. Multiple visualization modes (indiviual realizations, statistical lines, statistical fanchart, etc) and possibility to select which statistics to include.

Closes: #210
Closes: #211
Closes: #212

@jorgenherje jorgenherje self-assigned this Sep 1, 2023
@jorgenherje jorgenherje added the enhancement New feature or request label Sep 1, 2023
@jorgenherje jorgenherje force-pushed the improve-simulation-time-series branch from 1725290 to 812244e Compare September 5, 2023 07:38
- Functionality for adding multiple ensembles and vectors
- Group By ensemle or time series
- Add statistics and historical vector queries
- Remove specification on statistics function in query, get all and filter in front-end. To prevent new query on interaction owithstatistics checkboxes.
- Make fanchart options, pairwise min/max and p10/p90
- Make enum options upper case letters
update
- Create single builder to reduce repeated code. 
- Fix bug for loadedVectorSpecificationsAndHistoricalData in view.tsx. Got unequal length on vectorSpecification array and queryResult array in util method.
- Rename files and functions
- Remove unused code
- Move files
- Minor refactoring
@jorgenherje jorgenherje force-pushed the improve-simulation-time-series branch from cc279c2 to ca03b4a Compare September 5, 2023 13:11
@jorgenherje jorgenherje changed the title Improved Simulation Time Series Module SimulationTimeSeriesMatrix An improved Simulation Time Series Module Sep 5, 2023
@jorgenherje jorgenherje changed the title SimulationTimeSeriesMatrix An improved Simulation Time Series Module SimulationTimeSeriesMatrix -module - An improved Simulation Time Series Module Sep 5, 2023
@jorgenherje jorgenherje changed the title SimulationTimeSeriesMatrix -module - An improved Simulation Time Series Module SimulationTimeSeriesMatrix module Sep 5, 2023
@jorgenherje jorgenherje marked this pull request as ready for review September 5, 2023 13:56
@jorgenherje jorgenherje requested review from sigurdp and HansKallekleiv and removed request for sigurdp September 5, 2023 13:56
@jorgenherje jorgenherje requested a review from sigurdp September 5, 2023 15:54
- Added ApiStatesWrapper for list of react queries
- Handle selected vectors when deleting/removing ensembles
- Handle selected vectors when selecting new or non-cached ensemble
- Fix bug in use effect in settings, was `return` instead of `continue` in for-loop, thus not triggering update of view.
Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HansKallekleiv HansKallekleiv merged commit e0419b3 into equinor:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🏁
2 participants