-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimulationTimeSeriesMatrix
module
#293
Merged
HansKallekleiv
merged 10 commits into
equinor:main
from
jorgenherje:improve-simulation-time-series
Sep 6, 2023
Merged
SimulationTimeSeriesMatrix
module
#293
HansKallekleiv
merged 10 commits into
equinor:main
from
jorgenherje:improve-simulation-time-series
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1725290
to
812244e
Compare
- Functionality for adding multiple ensembles and vectors - Group By ensemle or time series - Add statistics and historical vector queries
- Remove specification on statistics function in query, get all and filter in front-end. To prevent new query on interaction owithstatistics checkboxes. - Make fanchart options, pairwise min/max and p10/p90 - Make enum options upper case letters update
- Create single builder to reduce repeated code. - Fix bug for loadedVectorSpecificationsAndHistoricalData in view.tsx. Got unequal length on vectorSpecification array and queryResult array in util method.
- Rename files and functions - Remove unused code - Move files - Minor refactoring
cc279c2
to
ca03b4a
Compare
SimulationTimeSeriesMatrix
An improved Simulation Time Series Module
SimulationTimeSeriesMatrix
An improved Simulation Time Series ModuleSimulationTimeSeriesMatrix
-module - An improved Simulation Time Series Module
SimulationTimeSeriesMatrix
-module - An improved Simulation Time Series ModuleSimulationTimeSeriesMatrix
module
- Added ApiStatesWrapper for list of react queries - Handle selected vectors when deleting/removing ensembles - Handle selected vectors when selecting new or non-cached ensemble - Fix bug in use effect in settings, was `return` instead of `continue` in for-loop, thus not triggering update of view.
HansKallekleiv
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version - more functionality to be added.
Improved Simulation time series module for plotting multiple ensembles and vectors, with subplots. Multiple visualization modes (indiviual realizations, statistical lines, statistical fanchart, etc) and possibility to select which statistics to include.
Closes: #210
Closes: #211
Closes: #212