Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended functionality in EnsembleParameters #297

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Extended functionality in EnsembleParameters #297

merged 5 commits into from
Sep 11, 2023

Conversation

sigurdp
Copy link
Collaborator

@sigurdp sigurdp commented Sep 10, 2023

  • Extended functionality in EnsembleParameters class
  • Introduced MinMax class for storing a min/max range

@sigurdp sigurdp marked this pull request as ready for review September 11, 2023 06:51
@sigurdp sigurdp requested a review from jorgenherje September 11, 2023 06:51
jorgenherje
jorgenherje requested changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice functionality!

Minor comments

frontend/src/framework/EnsembleParameters.ts Outdated Show resolved Hide resolved
frontend/src/framework/EnsembleParameters.ts Show resolved Hide resolved
frontend/src/framework/EnsembleParameters.ts Outdated Show resolved Hide resolved
frontend/tests/unit-tests/EnsembleParameters.test.ts Show resolved Hide resolved
@sigurdp sigurdp requested a review from jorgenherje September 11, 2023 16:15
jorgenherje
jorgenherje approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sigurdp sigurdp merged commit 6147245 into equinor:main Sep 11, 2023
3 checks passed
@sigurdp sigurdp deleted the ensemble-parameters branch September 12, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje jorgenherje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigurdp @jorgenherje