Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor surface directory #298

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Sep 11, 2023

  • Replace existing StaticSurfaceDirectory and DynamicSurfaceDirectory endpoints and service layer with a single SurfaceDirectory, which is a list of all surfaces with additional metadata sorted by stratigraphical order. Non-stratigraphical surfaces are placed last in the list.

  • Rename surface metadata to more descriptive properties.

  • Move some of the logic of filtering the directory to a typescript class

  • [ ] Add reusable SurfaceSelect react component

  • Update existing Map and TopographicMap modules to use the new directory

  • Add stratigraphy ordering from Smda.

  • Update remaining endpoints and logic to retrieve the surface data

Closes #265

@HansKallekleiv HansKallekleiv force-pushed the surface-dir-refactor branch 2 times, most recently from 9f97910 to 33b9e9c Compare September 12, 2023 11:27
@HansKallekleiv HansKallekleiv force-pushed the surface-dir-refactor branch 2 times, most recently from ae39481 to cf79ef1 Compare September 18, 2023 16:58
@rubenthoms rubenthoms self-requested a review September 20, 2023 11:46
@anders-kiaer anders-kiaer removed the request for review from rubenthoms September 25, 2023 07:42
Copy link
Collaborator

@sigurdp sigurdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HansKallekleiv HansKallekleiv merged commit 814781d into equinor:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve categorization of Sumo surface data
2 participants