Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed/improved multiple components #299

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Fixed/improved multiple components #299

merged 5 commits into from
Sep 11, 2023

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Sep 11, 2023 •
edited
Loading

  • Added scrollbar to module settings
  • Fixed issue with SmartNodeSelector tag buttons not being visible and removed Remove all button when nothing is selected
  • Reduced size of radio buttons, fixed size when long label, removed padding so it's aligned with e.g. checkboxes, added pointer cursor and hover effect
  • Increased size of checkbox text
  • Added close cross to ensemble dialog
  • Improved useElementBoundingRect hook to take scrolling into account

jorgenherje
jorgenherje reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Awaiting fix for dropdown suggestions list when scrolling settings area.

jorgenherje
jorgenherje approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice fixes!

@rubenthoms rubenthoms merged commit a709eea into equinor:main Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje jorgenherje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenthoms @jorgenherje