Show multiple sensitivities in TimeSeriesSensitivities module #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKallekleiv
force-pushed
the
timeseries-sens-show-all-sens
branch
2 times, most recently
from
a8136a0 to
d2c3d74
Compare
jorgenherje
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Nice work! Like the functionality!
I would like to get some message in the Tornado Chart when a time step is not selected. It can be difficult to see/know that the Tornado Chart awaits a click in the Simulation Time Series per sensitivity-module to get an active time stamp. Not sure what is the best way to inform the user of this?
Otherwise some minor comments.
frontend/src/modules/SimulationTimeSeriesSensitivity/queryHooks.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/simulationTimeSeriesChart/traces.ts
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/simulationTimeSeriesChart/traces.ts
Outdated
Show resolved
Hide resolved
HansKallekleiv
force-pushed
the
timeseries-sens-show-all-sens
branch
from
dca5054 to
1f040ca
Compare
jorgenherje
requested changes
Sep 20, 2023
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/SimulationTimeSeriesSensitivity/settings.tsx
Outdated
Show resolved
Hide resolved
HansKallekleiv
force-pushed
the
timeseries-sens-show-all-sens
branch
from
cd01027 to
e025de4
Compare
jorgenherje
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to show more than one sensitivity in TimeSeriesSensitivities module.
Rename module and template.
Awaits #315