Proposal for handling of missing/removed modules #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKallekleiv
approved these changes
Sep 13, 2023
jorgenherje
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
I really like this feature! When working with multiple branches the layout might contain non-existing modules when switching between these. I would prefer to be able to keep my selected ensembles, and not clear the entire local storage. This PR resolves this need!
This is of course most for development, and not a major need for end user. Removal or renaming of modules might not occur often.
The picture below is a nice feature in my opinion, where I'm able to easily remove the non-existing module and keeping keep on working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal enables the user to recover kindly (keeping other module instances in the layout) when a module in the stored layout no longer exists.