Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor of well completion backend and frontend #311

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Minor refactor of well completion backend and frontend #311

merged 2 commits into from
Sep 15, 2023

Conversation

sigurdp
Copy link
Collaborator

@sigurdp sigurdp commented Sep 14, 2023

Refactored well completion backend and frontend slightly in preparation for introducing new version of FastAPI and Pydantic.

  • Removed None as attribute type until we're sure we need it
  • Refactored and cleaned up frontend data accessor class in preparation new FastAPI version

There should be no functional changes

@sigurdp sigurdp requested a review from jorgenherje September 14, 2023 15:02
jorgenherje
jorgenherje approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sigurdp sigurdp merged commit 2c30c89 into equinor:main Sep 15, 2023
3 checks passed
@sigurdp sigurdp deleted the well-completion-refactor branch September 15, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje jorgenherje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigurdp @jorgenherje