Refactor WellCompletions back-end code #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgenherje
force-pushed
the
314-refactor-well-completion-code
branch
2 times, most recently
from
9a2b90b to
86a4853
Compare
jorgenherje
force-pushed
the
314-refactor-well-completion-code
branch
from
86a4853 to
956c4e1
Compare
- Remove unnecessary schema - Fixup in types: remove inheritance and improve naming - Refactor utility code into accessor code/file - Update usage in front-end
Singular to plural naming
- Validation method - Clean copy when all common columns are equal
- Generate api after rebase - Fix plurar
jorgenherje
force-pushed
the
314-refactor-well-completion-code
branch
from
956c4e1 to
7b29774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code for WellCompletions-module:
Back-end:
WellCompletiontoWellCompletionsWellCompletionsDatadirectly fromwell_completions_access- do not expose pandas DataFrame structure.well_completions_utils-code intowell_compltions_access.pyand rename toWellCompletionDataConverterwell_completions/router.pyupdate usage according to update ofWellCompletionsAccesswell_completions_types.pyRemove unneeded inheritance and fix naming to plural.Front-end:
Closes: #314