Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to SmartNodeSelector/VectorSelector #318

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Fixes to SmartNodeSelector/VectorSelector #318

merged 7 commits into from
Sep 25, 2023

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Sep 18, 2023 •
edited
Loading

  • Better information when more nodes selected than allowed (via wildcards)
  • Reverted disabled wildcards in single-node selection
  • Bugfix when blurring selector

Fixes #315.

@rubenthoms rubenthoms added bug Something isn't working enhancement New feature or request labels Sep 18, 2023
@rubenthoms rubenthoms self-assigned this Sep 18, 2023
@rubenthoms rubenthoms changed the title Fixes to vector selector Fixes to SmartNodeSelector/VectorSelector Sep 18, 2023
jorgenherje
jorgenherje reviewed Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Awaiting potential fix for discussed bug with backspace issue.

@rubenthoms rubenthoms merged commit 1442657 into equinor:main Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje jorgenherje approved these changes

Assignees

@rubenthoms rubenthoms

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VectorSelector with maxNumSelectedNodes=1 breaks free text search for vector name
2 participants
@rubenthoms @jorgenherje