-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color by parameter for SimulationTimeSeriesMatrix #320
Add color by parameter for SimulationTimeSeriesMatrix #320
Conversation
f1f778c
to
1f9c8c1
Compare
37bdfb0
to
1333d17
Compare
05804b2
to
0c0fe37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
A few general comments from an end-user perspective:
- Consider instead of having an empty plot as default, change the default plot title to e.g. "Select a vector to visualize"
- Consider collapsing some of the settings to highlight the important bit. E.g. keep ensembles and vector selection open, but collapse the others.
- The parameter list will be overwhelming if you don't know what to look for. Not directly related to this PR but we need both filtering of parameters(e.g. based on group) and sorting of parameters on how "important" they are. We can do this by calculating the correlation of the parameter values to the timeseries at a given date. I think we could automate this by selecting the last date (automatically) and perform the correlation. There exists an early attempt of an endpoint on the api to do this correlation: https://github.com/equinor/webviz/blob/main/backend/src/backend/primary/routers/correlations/router.py
- Also not related to this PR, but we should use the full name of the vectors, instead of the shortname as the plot title. (FOPT = Field Oil Production)
Nice feedback!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some comments to consider.
frontend/src/modules/SimulationTimeSeriesMatrix/utils/ensemblesVectorListHelper.ts
Outdated
Show resolved
Hide resolved
eb798f1
to
e4ca667
Compare
- Rename to continuous - improve constructor to remove cast (usage of `as`)
- Fix bug with propagation of selected parameter from settings to view (useValidState in view) - Minor code cleanup for readability
e4ca667
to
cf9c0a1
Compare
Add coloring of realization by parameter for selected vectors.
EnsemblesContinuousParameterColoring
- Utility class to work with the parameter values across multiple selected ensembles.Subplot builder:
createVectorTracesUtils.py
- Refactored by creating types for function argument options. To easier work with optional and default arguments.Closes: #219