Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to GUI #340

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Improvements to GUI #340

merged 3 commits into from
Sep 23, 2023

Conversation

rubenthoms
Copy link
Collaborator

  • Changed icon set to MUI/Google Material Icons (replaced all icons)
  • Modules only highlighted when in modules settings/sync settings
  • Removed LoginDialog and replaced with StartScreen
  • Opening module list when layout is empty (all modules removed)
  • Added optional description to modules and added info dialog to modules list items

- Changed icon set to MUI/Google Material Icons (replaced all icons)
- Modules only highlighted when in modules settings/sync settings
- Removed LoginDialog and replaced with StartScreen
- Opening module list when layout is empty (all modules removed)
- Added optional description to modules and added info dialog to modules list items
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great. The code changes also looks good to me 👍

The only thing I'm a bit unsure of if we going forward will need the dialog box for showing module descriptions, or if tooltip on hover is enough (showing only some short formatted description text). Currently I envision tooltip with description text would be enough (and also be an easier/cleaner user interface), but might be wrong.

@rubenthoms
Copy link
Collaborator Author

Tested, works great. The code changes also looks good to me 👍

The only thing I'm a bit unsure of if we going forward will need the dialog box for showing module descriptions, or if tooltip on hover is enough (showing only some short formatted description text). Currently I envision tooltip with description text would be enough (and also be an easier/cleaner user interface), but might be wrong.

I am also not a big fan of the dialog. However, users with touch devices might not be able to access tooltips. I removed the dialog now for the first implementation. We can decide later on how we are dealing with this.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rubenthoms rubenthoms merged commit dc926f5 into equinor:main Sep 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment