Added user avatar to logged_in_user route and adjusted frontend
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from pydantic import BaseModel | ||
| # Using the same http client as sumo | ||
| import httpx | ||
| import base64 |
There was a problem hiding this comment.
Move this line to top import group (base64 is std.lib)?
Comment on lines
+63
to
+71
| async with httpx.AsyncClient() as client: | ||
| result = await client.get("https://graph.microsoft.com/v1.0/me/photo/$value", headers=headers) | ||
| if result.status_code == 200: | ||
| user_info.avatar_b64str = base64.b64encode(result.content) | ||
|
|
||
| async with httpx.AsyncClient() as client: | ||
| result = await client.get("https://graph.microsoft.com/v1.0/me", headers=headers) | ||
| if result.status_code == 200: | ||
| user_info.display_name = json.loads(result.content.decode("utf-8")).get("displayName", None) |
There was a problem hiding this comment.
I don't know httpx enough yet to immediately know the answer to this: Are these two calls done sequentially here? If they are, and since they are independent, we could perhaps do them in parallell and just await until both are done before returning? Should speed up the logged_in_user response time in that case.
| try: | ||
| self.get_graph_access_token() | ||
| return True | ||
| except: |
There was a problem hiding this comment.
Suggested change
| except: | |
| except ValueError: |
| @@ -28,6 +30,19 @@ def __eq__(self, other: Any) -> bool: | |||
|
|
|||
| def get_username(self) -> str: | |||
| return self._username | |||
|
|
|||
| def get_graph_access_token(self) -> str: | |||
| if isinstance(self._graph_access_token, str) and len(self._graph_access_token) > 0: | |||
There was a problem hiding this comment.
Suggested change
| if isinstance(self._graph_access_token, str) and len(self._graph_access_token) > 0: | |
| if isinstance(self._graph_access_token, str) and self._graph_access_token: |
| <img | ||
| src={`data:image/png;base64,${userInfo.avatar_b64str}`} | ||
| alt="Avatar" | ||
| className="w-4 h-4 rounded-full" |
There was a problem hiding this comment.
Should we make the picture slightly larger, same size as icon?
Suggested change
| className="w-4 h-4 rounded-full" | |
| className="w-5 h-5 rounded-full" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332.