Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get profile picture and user details from Microsoft Graph API #344

Merged

Conversation

rubenthoms
Copy link
Collaborator

Fetching profile picture and user details from Microsoft Graph API. Taking in use asyncio backend for simultaneous get requests.

Closes #332.

@rubenthoms rubenthoms added the enhancement New feature or request label Sep 22, 2023
@rubenthoms rubenthoms self-assigned this Sep 22, 2023
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, otherwise LGTM! 🚀🙂

backend/src/services/utils/authenticated_user.py Outdated Show resolved Hide resolved
backend/src/backend/primary/routers/general.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice getting httpx in 👍
We should do the same for the other http requests we have.
SMDA: #346
Upcoming PR for VDS: #319

@rubenthoms rubenthoms merged commit 108958d into equinor:main Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to user avatar when logged in
3 participants