Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter list filtering #404

Merged
merged 11 commits into from
Oct 10, 2023

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Oct 5, 2023

Component to create a filtered subset of a Parameter list.

Utillizing the SmartNodeSelector to filter on the properties of the Parameter-type.


Closes: #405

@jorgenherje jorgenherje added the enhancement New feature or request label Oct 5, 2023
@jorgenherje jorgenherje self-assigned this Oct 5, 2023
@jorgenherje jorgenherje force-pushed the ensemble-parameters-filtering branch from 73d54d5 to 8d77953 Compare October 5, 2023 18:44
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good to me. 👍 There are a few things that need to be fixed and some comments/suggestions.

@jorgenherje jorgenherje requested a review from rubenthoms October 9, 2023 12:12
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jorgenherje jorgenherje merged commit 09407b3 into equinor:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter list filtering
2 participants