-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter list filtering #404
Merged
jorgenherje
merged 11 commits into
equinor:main
from
jorgenherje:ensemble-parameters-filtering
Oct 10, 2023
Merged
Parameter list filtering #404
jorgenherje
merged 11 commits into
equinor:main
from
jorgenherje:ensemble-parameters-filtering
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgenherje
force-pushed
the
ensemble-parameters-filtering
branch
from
October 5, 2023 18:44
73d54d5
to
8d77953
Compare
rubenthoms
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good to me. 👍 There are a few things that need to be fixed and some comments/suggestions.
frontend/src/framework/components/ParameterListFilter/private-utils/smartNodeSelectorUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/framework/components/ParameterListFilter/private-utils/smartNodeSelectorUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/framework/components/ParameterListFilter/private-utils/smartNodeSelectorUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/framework/components/ParameterListFilter/private-utils/smartNodeSelectorUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/framework/components/ParameterListFilter/parameterListFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/framework/components/ParameterListFilter/parameterListFilter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/framework/components/ParameterListFilter/parameterListFilter.tsx
Outdated
Show resolved
Hide resolved
Revert usage of function for code. Improved naming for readability.
rubenthoms
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component to create a filtered subset of a
Parameter
list.Utillizing the
SmartNodeSelector
to filter on the properties of the Parameter-type.Closes: #405