Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change time series module previews #428

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Change time series module previews #428

merged 1 commit into from
Oct 17, 2023

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented Oct 17, 2023 •
edited
Loading

Closes #339. Changing preview of time series modules

From:
image

To:
image

@anders-kiaer anders-kiaer marked this pull request as ready for review October 17, 2023 07:21
@anders-kiaer anders-kiaer requested review from jorgenherje and rubenthoms and removed request for jorgenherje October 17, 2023 07:21
@anders-kiaer anders-kiaer self-assigned this Oct 17, 2023
rubenthoms
rubenthoms approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice graphics 👍

jorgenherje
jorgenherje approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

General comment for preview-visualization for modules:
I see most of the .svg, .webp and similar files, provided as src for the <img> element, are placed at "top level" in the respective module. Should these files/sources for the <img> element be placed in a folder, e.g. private-assets in the modules?

@anders-kiaer anders-kiaer mentioned this pull request Oct 17, 2023
Open
@anders-kiaer
Copy link
Collaborator Author

Looks good to me! 👍

General comment for preview-visualization for modules: I see most of the .svg, .webp and similar files, provided as src for the <img> element, are placed at "top level" in the respective module. Should these files/sources for the <img> element be placed in a folder, e.g. private-assets in the modules?

Good question. Separated this into a separate issue, as it also as you say also include the other existing/unchanged modules.

@anders-kiaer anders-kiaer merged commit fd2c64a into main Oct 17, 2023
@anders-kiaer anders-kiaer deleted the timeseries branch October 17, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje jorgenherje approved these changes

@rubenthoms rubenthoms rubenthoms approved these changes

Assignees

@anders-kiaer anders-kiaer

Labels
None yet
Projects
None yet
Milestone
Network meeting demo freeze
Development

Successfully merging this pull request may close these issues.

Change from dynamically to statically created preview SVGs
3 participants
@anders-kiaer @rubenthoms @jorgenherje