Support latest sumo metadata #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HansKallekleiv
commented
Oct 22, 2023
•
HansKallekleiv
commented
- Use new Sumo parameter table collection for retrieving parameters
- Use new metadata definition for Sumo Summary data
- Handle surfaces with missing metadata
- Set default sumo environment to production
anders-kiaer
approved these changes
Oct 23, 2023
|
|
||
| sensitivities = create_ensemble_sensitivities(sumo_parameters) | ||
| parameters = [create_ensemble_parameter(sumo_parameter) for sumo_parameter in sumo_parameters] | ||
| table = table_collection[0] |
There was a problem hiding this comment.
Suggested change
| table = table_collection[0] | |
| table = await table_collection.getitem_async(0) |
| sensitivities = create_ensemble_sensitivities(sumo_parameters) | ||
| parameters = [create_ensemble_parameter(sumo_parameter) for sumo_parameter in sumo_parameters] | ||
| table = table_collection[0] | ||
| byte_stream: BytesIO = table.blob |
There was a problem hiding this comment.
Should this be async in some way?
There was a problem hiding this comment.
There is a table.blob_async which do return a BytesIO object, but the following lines:
table = await table_collection.getitem_async(0)
byte_stream: BytesIO = await table.blob_async
table = pq.read_table(byte_stream)gives: pyarrow.lib.ArrowInvalid: Could not open Parquet input source '<Buffer>': Parquet magic bytes not found in footer. Either the file is corrupted or this is not a parquet file.
Not entirely sure why...
Comment on lines
295
to
311
| def get_smry_table_collection(case: Case, iteration_name: str, column_name: Optional[str] = None) -> TableCollection: | ||
| """Get a collection of summary tables for a case and iteration""" | ||
| all_smry_table_collections = case.tables.filter( | ||
| aggregation="collection", | ||
| tagname="summary", | ||
| iteration=iteration_name, | ||
| column=column_name, | ||
| ) | ||
| table_names = all_smry_table_collections.names | ||
| if len(table_names) == 0: | ||
| raise ValueError("No summary table collections found") | ||
| if len(table_names) == 1: | ||
| return all_smry_table_collections | ||
|
|
||
| raise ValueError(f"Multiple summary table collections found: {table_names}. Expected only one.") |
There was a problem hiding this comment.
Should this function also be async, and use async/await on its calls to sumo?
HansKallekleiv
force-pushed
the
support-latest-sumo-metadata
branch
from
6cf2728 to
c6305a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.