-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from openapi-typescript-codegen
to @hey-api/openapi-ts
#768
Conversation
Changes do still require testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems in order, functionality-wise. The new structure seems fine aswell.
Only tested modules Im acquainted with, so can only speak to the functionality of the 3D-Viewer, Flow Network, Intersection, and Well log viewer modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested some modules and inspected minor part of code to see changes. Looks good to me!
Created custom script for adding
_api
suffix to auto-generated API types while waiting for hey-api/openapi-ts#960.Regarding changes to
staleTime
andgcTime
, here is a list of all occurences:All others were set to 1000 * 60 = 1 min. This is now the default value and does not need to be set individually anymore.
How should we proceed with the other values?
Closes #740
Closes #787
Review could especially focus on functionality - are modules still working as expected?