Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from openapi-typescript-codegen to @hey-api/openapi-ts #768

Merged
merged 15 commits into from
Jan 15, 2025

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Oct 23, 2024

Created custom script for adding _api suffix to auto-generated API types while waiting for hey-api/openapi-ts#960.

Regarding changes to staleTime and gcTime, here is a list of all occurences:

Occurence Stale time GC time
Ensembles 5 * 60 * 1000 = 5 min 5min
Ensembles dialog 0 5 min
Drilled well trajectories 1800000 1800000
grid polyline intersection 0 0

All others were set to 1000 * 60 = 1 min. This is now the default value and does not need to be set individually anymore.

How should we proceed with the other values?


Closes #740
Closes #787


Review could especially focus on functionality - are modules still working as expected?

@rubenthoms rubenthoms self-assigned this Oct 23, 2024
@rubenthoms rubenthoms added the enhancement New feature or request label Oct 24, 2024
Copy link
Collaborator

@Anders2303 Anders2303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems in order, functionality-wise. The new structure seems fine aswell.

Only tested modules Im acquainted with, so can only speak to the functionality of the 3D-Viewer, Flow Network, Intersection, and Well log viewer modules

Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested some modules and inspected minor part of code to see changes. Looks good to me!

@rubenthoms rubenthoms merged commit 716d7e4 into equinor:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done 🏁
4 participants