2D Viewer module #811
Merged
2D Viewer module #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hans Kallekleiv <[email protected]>
jorgenherje
requested changes
Dec 6, 2024
frontend/src/modules/2DViewer/settings/components/layerManagerComponent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/2DViewer/view/components/ReadoutWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/2DViewer/view/customDeckGlLayers/WellborePicksLayer.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/2DViewer/view/customDeckGlLayers/WellborePicksLayer.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/2DViewer/view/customDeckGlLayers/WellborePicksLayer.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/2DViewer/view/customDeckGlLayers/WellborePicksLayer.ts
Outdated
Show resolved
Hide resolved
jorgenherje
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Really nice and impressive work!👍
I've reviewed the general structure and general functionality, without diving too much into details. Just minor comments (sorry for a lot of repeating comments) with respect to naming and documentation for clarity.
In general, I prefer naming classes which implements an interface a name ending with the interface name. E.g. class RealizationItem implements Item {} vs class Realization implements Item {} - when we have an interface named Item. This can make it easier for the user when where RealizationItem component/class is used. As for the classes in the implementations/-folder.
frontend/src/modules/2DViewer/layers/implementations/layers/RealizationPolygonsLayer/types.ts
Outdated
Show resolved
Hide resolved
.../2DViewer/layers/implementations/layers/RealizationSurfaceLayer/RealizationSurfaceContext.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/2DViewer/layers/implementations/layers/RealizationSurfaceLayer/types.ts
Outdated
Show resolved
Hide resolved
.../2DViewer/layers/implementations/layers/StatisticalSurfaceLayer/StatisticalSurfaceContext.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/2DViewer/layers/implementations/layers/StatisticalSurfaceLayer/types.ts
Outdated
Show resolved
Hide resolved
jorgenherje
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #803.
Depends on: