Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group Tree / Flow Network] Refactor - Change use of "Group tree" to "Flow network" #813

Conversation

Anders2303
Copy link
Collaborator

Renames a bunch, and moves some definitions and files to hopefully make the difference between Sumo's "Group Trees" and the webwiz rendered "group tree plot" more clear

Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A lot of nice adjustments with respect to separating into functions for cleanness and readability.

Some comments regarding naming, function attributes and usage of pd.Series

- Renaming back-end
- Minor adjustments/refactoring back-end
- Move type converting to view in front-end
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I adjusted according to discussion

@jorgenherje jorgenherje merged commit 7e96080 into equinor:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants