-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group Tree / Flow Network] Refactor - Change use of "Group tree" to "Flow network" #813
[Group Tree / Flow Network] Refactor - Change use of "Group tree" to "Flow network" #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A lot of nice adjustments with respect to separating into functions for cleanness and readability.
Some comments regarding naming, function attributes and usage of pd.Series
backend_py/primary/primary/services/sumo_access/group_tree_types.py
Outdated
Show resolved
Hide resolved
backend_py/primary/primary/services/sumo_access/group_tree_types.py
Outdated
Show resolved
Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py
Outdated
Show resolved
Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py
Show resolved
Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py
Outdated
Show resolved
Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py
Outdated
Show resolved
Hide resolved
backend_py/primary/primary/services/flow_network_assembler/flow_network_assembler.py
Outdated
Show resolved
Hide resolved
- Renaming back-end - Minor adjustments/refactoring back-end - Move type converting to view in front-end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I adjusted according to discussion
…roup-tree-to-flow-network
Renames a bunch, and moves some definitions and files to hopefully make the difference between Sumo's "Group Trees" and the webwiz rendered "group tree plot" more clear