-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Build against numpy >= 2.0.0rc1 #1233
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,7 +116,12 @@ def test_assign(): | |
# this shall now broadcast the value 33 to all activecells | ||
x.isdiscrete = True | ||
x.values = 33 | ||
assert x.dtype == np.int32 | ||
|
||
numpy_version = tuple(map(int, np.__version__.split("."))) | ||
if numpy_version >= (2, 0, 0): | ||
assert x.dtype == np.int64 | ||
else: | ||
assert x.dtype == np.int32 | ||
Comment on lines
+121
to
+124
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably take another look into this and if there are implications for file sizes There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this indicate some problems with backward compatibility? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to test this more |
||
|
||
x.isdiscrete = False | ||
x.values = 44.0221 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this should be replaced without proper testing. The reason is that numpy version for RMS is pinned, and to avoid ABI version issues we should compile on the oldest version of numpy that is supported by a given python version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that we will need to do some thorough testing. A few good indicators so far:
numpy==1.24.3