Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP: Drop Python 3.8 support #1282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DEP: Drop Python 3.8 support #1282

wants to merge 1 commit into from

Conversation

mferrera
Copy link
Collaborator

Resolves #1277

@mferrera mferrera self-assigned this Dec 12, 2024
@mferrera
Copy link
Collaborator Author

The required Python 3.8 checks will stay in an expecting state until they're removed from repo settings (i.e. after this PR).

@mferrera mferrera requested a review from jcrivenaes December 12, 2024 07:06
mferrera
mferrera commented Dec 12, 2024
View reviewed changes
pyproject.toml
@@ -120,7 +118,6 @@ match = '(?!(test_|_)).*\.py'

[tool.pytest.ini_options]
minversion = "6.0"
addopts = "--verbose"
Copy link
Collaborator Author

@mferrera mferrera Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to reduce the 1500 line terminal flood when running the tests down to a grid of dots

mferrera
mferrera commented Dec 12, 2024
View reviewed changes
pyproject.toml
Comment on lines +143 to +148
# "B", # flake-8-bugbear
"C", # pylint-convention
"E", # pycodestyle-error
"F", # pyflakes
"I", # isort
# "NPY", # numpy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few extra linting jobs that would be nice to add, with labels of what these are

mferrera
mferrera commented Dec 12, 2024
View reviewed changes
tests/test_grid3d/test_grdecl_format.py
Comment on lines +25 to +26
patch(
"builtins.open",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff wanted to do this now, idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrivenaes jcrivenaes Awaiting requested review from jcrivenaes

At least 1 approving review is required to merge this pull request.

Assignees

@mferrera mferrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8
1 participant
@mferrera