CI: overwrite with RMS package versions #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
+ Coverage 80.02% 81.15% +1.12%
==========================================
Files 98 94 -4
Lines 13680 12438 -1242
Branches 2203 1874 -329
==========================================
- Hits 10948 10094 -854
+ Misses 1999 1685 -314
+ Partials 733 659 -74 ☔ View full report in Codecov by Sentry. |
jcrivenaes
reviewed
Jan 10, 2025
| @@ -222,7 +222,7 @@ def _get_roff_type_and_size( | |||
| return "float", value.size, value.size * (4 if is_binary else 5) | |||
| if np.issubdtype(value.dtype, np.double): | |||
| return "double", value.size, value.size * (8 if is_binary else 9) | |||
| if np.issubdtype(value.dtype, np.unicode_): | |||
| if np.issubdtype(value.dtype, np.str_): | |||
There was a problem hiding this comment.
I will guess this is safe for numpy 1 also?
There was a problem hiding this comment.
Yep, I see it as far back as numpy 1.20 at least (may be earlier as well)
|
Added an extra commit for the new ruff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1288