ENH: add a method that creates a grid property between two input surfaces #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit focus on the python frontend
jcrivenaes
commented
Jan 10, 2025
| @@ -5,7 +5,7 @@ ignore_missing_imports = True | |||
| strict_equality = True | |||
| warn_redundant_casts = True | |||
| warn_unused_configs = True | |||
| warn_unused_ignores = True | |||
| warn_unused_ignores = False | |||
There was a problem hiding this comment.
Changed this as it seems that mypy messages are incorrect (the # type: ignore is needed, but mypy claims it is not)
jcrivenaes
commented
Jan 10, 2025
| } | ||
| } | ||
| return std::make_tuple(xmid, ymid, zmid); | ||
| } |
There was a problem hiding this comment.
As a note, manual testing indicates that this function in pybind11 is 2-3 times faster than the corresponding function using swig (which it now replaces).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 80.02% 81.11% +1.08%
==========================================
Files 98 94 -4
Lines 13680 12483 -1197
Branches 2203 1882 -321
==========================================
- Hits 10948 10126 -822
+ Misses 1999 1693 -306
+ Partials 733 664 -69 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1290 as derived task from https://github.com/equinor/fmu-orion-playground/issues/19
Contributes also to #1247