ERC-6900 RI Test CI

[4/n permissions] feat: add native token spend limit plugin #223

Sign in to view logs

Triggered via pull request June 12, 2024 23:42

howydev

synchronize #71

howy/add-native-token-limit-plugin

Status Success

Total duration 50s

Artifacts –

test.yml

on: pull_request

Run Forge Tests (optimized-test-deep)

Run Forge Tests (default)

Annotations

5 warnings

Run Forge Tests (default)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run Linters

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run Linters: src/plugins/NativeTokenLimitPlugin.sol#L83

Function order is incorrect, external function can not go after external pure function (line 77)

Run Linters: test/account/AccountPermissionHooks.t.sol#L238

When fallback is not payable you will not be able to receive ether

Run Forge Tests (optimized-test-deep)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.