Skip to content

[5/n permissions] feat: add erc20 token limit plugin #235

[5/n permissions] feat: add erc20 token limit plugin

[5/n permissions] feat: add erc20 token limit plugin #235

Triggered via pull request June 16, 2024 22:03
Status Success
Total duration 58s
Artifacts

test.yml

on: pull_request
Run Linters
32s
Run Linters
Run Forge Tests (optimized-test-deep)
47s
Run Forge Tests (optimized-test-deep)
Run Forge Tests (default)
35s
Run Forge Tests (default)
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
Run Linters
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Linters: src/plugins/ERC20TokenLimitPlugin.sol#L31
Function order is incorrect, struct definition can not go after state variable declaration (line 29)
Run Linters: src/plugins/ERC20TokenLimitPlugin.sol#L62
Possible reentrancy vulnerabilities. Avoid state changes after transfer
Run Linters: src/plugins/NativeTokenLimitPlugin.sol#L85
Function order is incorrect, external function can not go after external pure function (line 79)
Run Linters: test/account/AccountPermissionHooks.t.sol#L238
When fallback is not payable you will not be able to receive ether
Run Forge Tests (default)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Forge Tests (optimized-test-deep)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.