Skip to content

[DRAFT] [6/n permissions] feat: add cold storage plugin #377

[DRAFT] [6/n permissions] feat: add cold storage plugin

[DRAFT] [6/n permissions] feat: add cold storage plugin #377

Triggered via pull request June 28, 2024 20:18
Status Failure
Total duration 37s
Artifacts

test.yml

on: pull_request
Run Linters
29s
Run Linters
Run Forge Tests (optimized-test-deep)
12s
Run Forge Tests (optimized-test-deep)
Run Forge Tests (default)
19s
Run Forge Tests (default)
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 7 warnings
Run Forge Tests (optimized-test-deep)
Process completed with exit code 1.
Run Forge Tests (default)
Process completed with exit code 1.
Run Forge Tests (optimized-test-deep)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Forge Tests (default)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Linters
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Linters: src/plugins/ColdStoragePlugin.sol#L114
Function order is incorrect, external view function can not go after internal view function (line 79)
Run Linters: src/plugins/ERC20TokenLimitPlugin.sol#L31
Function order is incorrect, struct definition can not go after state variable declaration (line 29)
Run Linters: src/plugins/ERC20TokenLimitPlugin.sol#L68
Possible reentrancy vulnerabilities. Avoid state changes after transfer
Run Linters: src/plugins/NativeTokenLimitPlugin.sol#L78
Function order is incorrect, external pure function can not go after internal function (line 55)