Skip to content

[DRAFT] [6/n permissions] feat: add cold storage plugin #382

[DRAFT] [6/n permissions] feat: add cold storage plugin

[DRAFT] [6/n permissions] feat: add cold storage plugin #382

Triggered via pull request July 8, 2024 17:40
Status Failure
Total duration 2m 48s
Artifacts

test.yml

on: pull_request
Run Linters
2m 37s
Run Linters
Run Forge Tests (optimized-test-deep)
21s
Run Forge Tests (optimized-test-deep)
Run Forge Tests (default)
10s
Run Forge Tests (default)
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 6 warnings
Run Forge Tests (default)
Process completed with exit code 1.
Run Forge Tests (optimized-test-deep)
Process completed with exit code 1.
Run Forge Tests (default)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Forge Tests (optimized-test-deep)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Linters
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Linters: src/plugins/ColdStoragePlugin.sol#L114
Function order is incorrect, external view function can not go after internal view function (line 79)
Run Linters: src/plugins/ERC20TokenLimitPlugin.sol#L31
Function order is incorrect, struct definition can not go after state variable declaration (line 29)
Run Linters: src/plugins/ERC20TokenLimitPlugin.sol#L68
Possible reentrancy vulnerabilities. Avoid state changes after transfer