Skip to content

Allow direct plugin calls with validation & permission hooks #409

Allow direct plugin calls with validation & permission hooks

Allow direct plugin calls with validation & permission hooks #409

Triggered via pull request July 11, 2024 16:38
Status Failure
Total duration 2m 55s
Artifacts

test.yml

on: pull_request
Run Linters
23s
Run Linters
Run Forge Tests (optimized-test-deep)
2m 45s
Run Forge Tests (optimized-test-deep)
Run Forge Tests (default)
32s
Run Forge Tests (default)
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 6 warnings
Run Linters: test/account/DirectCallsFromPlugin.t.sol#L4
imported name IPlugin is not used
Run Linters: test/account/DirectCallsFromPlugin.t.sol#L4
imported name PluginManifest is not used
Run Linters: test/account/DirectCallsFromPlugin.t.sol#L5
imported name IPluginManager is not used
Run Linters: test/account/DirectCallsFromPlugin.t.sol#L12
'plugin' should start with _
Run Linters: test/mocks/plugins/DirectCallPlugin.sol#L4
imported name ManifestExecutionFunction is not used
Run Linters: test/mocks/plugins/DirectCallPlugin.sol#L8
imported name ResultCreatorPlugin is not used
Run Linters
Process completed with exit code 1.
Run Linters
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Linters: src/account/UpgradeableModularAccount.sol#L709
Function order is incorrect, internal function can not go after internal view function (line 696)
Run Linters: src/interfaces/IPlugin.sol#L62
Variable name must be in mixedCase
Run Linters: test/account/DirectCallsFromPlugin.t.sol#L12
Explicitly mark visibility of state
Run Forge Tests (default)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Forge Tests (optimized-test-deep)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/