ERC-6900 RI Test CI

Allow direct plugin calls with validation & permission hooks #432

Sign in to view logs

Triggered via pull request July 16, 2024 13:29

Zer0dot

synchronize #90

zer0dot/direct-plugin-calls

Status Failure

Total duration 2m 41s

Artifacts –

test.yml

on: pull_request

Run Forge Tests (optimized-test-deep)

Run Forge Tests (default)

Annotations

8 errors and 8 warnings

Run Linters: test/account/DirectCallsFromPlugin.t.sol#L5

imported name IPlugin is not used

Run Linters: test/account/DirectCallsFromPlugin.t.sol#L5

imported name PluginManifest is not used

Run Linters: test/account/DirectCallsFromPlugin.t.sol#L6

imported name IPluginManager is not used

Run Linters: test/account/DirectCallsFromPlugin.t.sol#L17

'plugin' should start with _

Run Linters: test/account/DirectCallsFromPlugin.t.sol#L18

'pluginFunctionReference' should start with _

Run Linters: test/mocks/plugins/DirectCallPlugin.sol#L4

imported name ManifestExecutionFunction is not used

Run Linters: test/mocks/plugins/DirectCallPlugin.sol#L9

imported name ResultCreatorPlugin is not used

Run Linters

Process completed with exit code 1.

Run Forge Tests (default)

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run Linters

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run Linters: src/account/UpgradeableModularAccount.sol#L717

Function order is incorrect, internal function can not go after internal view function (line 691)

Run Linters: test/account/DirectCallsFromPlugin.t.sol#L17

Explicitly mark visibility of state

Run Linters: test/account/DirectCallsFromPlugin.t.sol#L18

Explicitly mark visibility of state

Run Linters: test/mocks/plugins/DirectCallPlugin.sol#L36

Error message for require is too long: 43 counted / 32 allowed

Run Linters: test/mocks/plugins/DirectCallPlugin.sol#L42

Error message for require is too long: 44 counted / 32 allowed

Run Forge Tests (optimized-test-deep)

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/