Skip to content

Commit

Permalink
fix: old comments and code blocks
Browse files Browse the repository at this point in the history
  • Loading branch information
fangting-alchemy committed Aug 15, 2024
1 parent bd8b02b commit 13265f5
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 12 deletions.
5 changes: 2 additions & 3 deletions src/interfaces/IStandardExecutor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@ interface IStandardExecutor {
/// @return An array containing the return data from the calls.
function executeBatch(Call[] calldata calls) external payable returns (bytes[] memory);

/// @notice Execute a call using a specified runtime validation, as given in the first 21 bytes of
/// `authorization`.
/// @notice Execute a call using a specified runtime validation.
/// @param data The calldata to send to the account.
/// @param authorization The authorization data to use for the call. The first 21 bytes specifies which runtime
/// @param authorization The authorization data to use for the call. The first 24 bytes specifies which runtime
/// validation to use, and the rest is sent as a parameter to runtime validation.
function executeWithAuthorization(bytes calldata data, bytes calldata authorization)
external
Expand Down
25 changes: 16 additions & 9 deletions standard/ERCs/erc-6900.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ Each step is modular, supporting different implementations for each execution fu

**Modular Smart Contract Accounts** **MUST** implement

- `IAccount.sol` from [ERC-4337](./eip-4337.md).
- `IAccountExecute.sol` from [ERC-4337](./eip-4337.md).
- `IModuleManager.sol` to support installing and uninstalling modules.
- `IStandardExecutor.sol` to support open-ended execution. **Calls to modules through this SHOULD revert.**
Expand Down Expand Up @@ -210,10 +211,9 @@ interface IStandardExecutor {
/// @return An array containing the return data from the calls.
function executeBatch(Call[] calldata calls) external payable returns (bytes[] memory);
/// @notice Execute a call using a specified runtime validation, as given in the first 21 bytes of
/// `authorization`.
/// @notice Execute a call using a specified runtime validation.
/// @param data The calldata to send to the account.
/// @param authorization The authorization data to use for the call. The first 21 bytes specifies which runtime
/// @param authorization The authorization data to use for the call. The first 24 bytes specifies which runtime
/// validation to use, and the rest is sent as a parameter to runtime validation.
function executeWithAuthorization(bytes calldata data, bytes calldata authorization)
external
Expand Down Expand Up @@ -318,12 +318,11 @@ interface IModule is IERC165 {
/// @return A metadata struct describing the module.
function moduleMetadata() external pure returns (ModuleMetadata memory);
}
```

#### `IValidationModule.sol`

``````solidity
```solidity
interface IValidationModule is IModule {
/// @notice Run the user operation validationFunction specified by the `entityId`.
/// @param entityId An identifier that routes the call to different internal implementations, should there
Expand Down Expand Up @@ -370,10 +369,11 @@ interface IValidationModule is IModule {
bytes calldata signature
) external view returns (bytes4);
}
```

#### `IValidationHookModule.sol`

````solidity
```solidity
interface IValidationHookModule is IModule {
/// @notice Run the pre user operation validation hook specified by the `entityId`.
/// @dev Pre user operation validation hooks MUST NOT return an authorizer value other than 0 or 1.
Expand Down Expand Up @@ -416,10 +416,11 @@ interface IValidationHookModule is IModule {
// view
// returns (bytes4);
}
```

#### `IExecutionModule.sol`

````solidity
```solidity
struct ManifestExecutionFunction {
// The selector to install
bytes4 executionSelector;
Expand Down Expand Up @@ -451,10 +452,11 @@ interface IExecutionModule is IModule {
/// @return A manifest describing the contents and intended configuration of the module.
function executionManifest() external pure returns (ExecutionManifest memory);
}
```

#### `IExecutionHookModule.sol`

`````solidity
```solidity
interface IExecutionHookModule is IModule {
/// @notice Run the pre execution hook specified by the `entityId`.
/// @dev To indicate the entire call should revert, the function MUST revert.
Expand All @@ -475,6 +477,7 @@ interface IExecutionHookModule is IModule {
/// @param preExecHookData The context returned by its associated pre execution hook.
function postExecutionHook(uint32 entityId, bytes calldata preExecHookData) external;
}
```

### Module manifest

Expand Down Expand Up @@ -571,7 +574,7 @@ struct ModuleManifest {
ManifestExecutionHook[] executionHooks;
}
``````
```

### Expected behavior

Expand Down Expand Up @@ -708,3 +711,7 @@ It is worth mentioning that execution hooks have no awareness of other execution
## Copyright

Copyright and related rights waived via [CC0](../LICENSE.md).

```
```

0 comments on commit 13265f5

Please sign in to comment.