Skip to content

Commit

Permalink
fix: consistency in comments in IPluginExecutor interface and spec (#36)
Browse files Browse the repository at this point in the history
  • Loading branch information
jaypaik authored Jan 24, 2024
1 parent a178bd4 commit 149a1d5
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions standard/ERCs/erc-6900.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,16 +187,18 @@ This prevents accidental misconfiguration or misuse of plugins (both installed a
```solidity
interface IPluginExecutor {
/// @notice Execute a call from a plugin to another plugin, via an execution function installed on the account.
/// @dev Permissions must be granted to the calling plugin for the call to go through.
/// @param data Calldata to send to the plugin.
/// @dev Plugins are not allowed to call native functions on the account. Permissions must be granted to the
/// calling plugin for the call to go through.
/// @param data The calldata to send to the plugin.
/// @return The return data from the call.
function executeFromPlugin(bytes calldata data) external payable returns (bytes memory);
/// @notice Execute a call from a plugin to a non-plugin address.
/// @dev Permissions must be granted to the calling plugin for the call to go through.
/// @param target Address of the target to call.
/// @param value Value to send with the call.
/// @param data Calldata to send to the target.
/// @dev If the target is a plugin, the call SHOULD revert. Permissions must be granted to the calling plugin
/// for the call to go through.
/// @param target The address to be called.
/// @param value The value to send with the call.
/// @param data The calldata to send to the target.
/// @return The return data from the call.
function executeFromPluginExternal(address target, uint256 value, bytes calldata data)
external
Expand Down

0 comments on commit 149a1d5

Please sign in to comment.