Skip to content

Commit

Permalink
update wording on expected behaviors of val/exec installs
Browse files Browse the repository at this point in the history
  • Loading branch information
@fangting-alchemy
fangting-alchemy committed Aug 29, 2024
1 parent 453cef2 commit 6d3fae8
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions standard/ERCs/erc-6900.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -493,18 +493,18 @@ An execution function selector MUST not conflict with native ERC-4337 and ERC-69

During execution installation, the account MUST correctly set flags and other fields based on the incoming data and module manifest provided by users.

- the account MUST install all execution functions and set flags and fields accordingly as specified in the manifest.
- the account MUST install all execution functions and set flags and fields as specified in the manifest.
- the account MUST add all execution hooks as specified in the manifest.
- the account MUST add all supported interfaces as specified in the manifest.
- the account MUST call `onInstall` on the execution module to initialize the states.
- the account SHOULD add all supported interfaces as specified in the manifest.
- the account SHOULD call `onInstall` on the execution module to initialize the states if required by user.
- the account MUST emit `ExecutionInstalled` as defined in the interface for all installed executions.

During execution uninstallation, the account MUST correctly clear flags and other fields based on the incoming data and module manifest provided by users.

- the account MUST remove all execution functions and clear flags and fields accordingly as specified in the manifest.
- the account MUST remove all execution functions and clear flags and fields as specified in the manifest.
- the account MUST remove all execution hooks as specified in the manifest.
- the account MUST remove all supported interfaces as specified in the manifest.
- the account MUST call `onUnInstall` on the execution module to initialize the states and track call success.
- the account SHOULD call `onUnInstall` on the execution module to initialize the states and track call success if required by user.
- the account MUST emit `ExecutionUninstalled` as defined in the interface for all uninstalled executions.

#### Responsibilties of `StandardExecutor` and `ModuleExecutor`
Expand Down

0 comments on commit 6d3fae8

Please sign in to comment.