fix: update validation function references in comments

erc6900 · Aug 15, 2024 · 83dc7b1 · 83dc7b1
1 parent c5104b0
commit 83dc7b1
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/lib/account-abstraction b/lib/account-abstraction
diff --git a/lib/forge-std b/lib/forge-std
diff --git a/lib/openzeppelin-contracts b/lib/openzeppelin-contracts
diff --git a/src/interfaces/IAccountLoupe.sol b/src/interfaces/IAccountLoupe.sol
@@ -41,7 +41,7 @@ interface IAccountLoupe {
 
     /// @notice Get the validation data for a validation.
     /// @dev If the selector is a native function, the module address will be the address of the account.
-    /// @param validationFunction The validationFunction to get the data for.
+    /// @param validationFunction The validation function to get the data for.
     /// @return ValidationData The module address for this selector.
     function getValidationData(ModuleEntity validationFunction)
         external

diff --git a/src/interfaces/IValidationModule.sol b/src/interfaces/IValidationModule.sol
@@ -6,7 +6,7 @@ import {PackedUserOperation} from "@eth-infinitism/account-abstraction/interface
 import {IModule} from "./IModule.sol";
 
 interface IValidationModule is IModule {
-    /// @notice Run the user operation validationFunction specified by the `entityId`.
+    /// @notice Run the user operation validation function specified by the `entityId`.
     /// @param entityId An identifier that routes the call to different internal implementations, should there
     /// be more than one.
     /// @param userOp The user operation.
@@ -16,7 +16,7 @@ interface IValidationModule is IModule {
         external
         returns (uint256);
 
-    /// @notice Run the runtime validationFunction specified by the `entityId`.
+    /// @notice Run the runtime validation function specified by the `entityId`.
     /// @dev To indicate the entire call should revert, the function MUST revert.
     /// @param account the account to validate for.
     /// @param entityId An identifier that routes the call to different internal implementations, should there

diff --git a/standard/ERCs/erc-6900.md b/standard/ERCs/erc-6900.md
@@ -265,7 +265,7 @@ interface IAccountLoupe {
 
     /// @notice Get the validation data for a validation.
     /// @dev If the selector is a native function, the module address will be the address of the account.
-    /// @param validationFunction The validationFunction to get the data for.
+    /// @param validationFunction The validation function to get the data for.
     /// @return ValidationData The module address for this selector.
     function getValidationData(ModuleEntity validationFunction)
         external
@@ -324,7 +324,7 @@ interface IModule is IERC165 {
 
 ```solidity
 interface IValidationModule is IModule {
-    /// @notice Run the user operation validationFunction specified by the `entityId`.
+    /// @notice Run the user operation validation function specified by the `entityId`.
     /// @param entityId An identifier that routes the call to different internal implementations, should there
     /// be more than one.
     /// @param userOp The user operation.
@@ -334,7 +334,7 @@ interface IValidationModule is IModule {
         external
         returns (uint256);
 
-    /// @notice Run the runtime validationFunction specified by the `entityId`.
+    /// @notice Run the runtime validation function specified by the `entityId`.
     /// @dev To indicate the entire call should revert, the function MUST revert.
     /// @param account the account to validate for.
     /// @param entityId An identifier that routes the call to different internal implementations, should there
@@ -493,7 +493,7 @@ enum ManifestAssociatedFunctionType {
     // on external validation functions. It MUST NOT depend on external hooks, or installation will fail.
     DEPENDENCY,
     // Resolves to a magic value to always bypass runtime validation for a given function.
-    // This is only assignable on runtime validation functions. If it were to be used on a user op validationFunction,
+    // This is only assignable on runtime validation functions. If it were to be used on a user op validation function,
     // it would risk burning gas from the account. When used as a hook in any hook location, it is equivalent to not
     // setting a hook and is therefore disallowed.
     RUNTIME_VALIDATION_ALWAYS_ALLOW,
+ −		audits/ERC-4337 Account Abstraction Incremental Audit Report Feb 20 2024.pdf
+0 −1		deployments/arbitrum/.chainId
+0 −1,318		deployments/arbitrum/EntryPoint.json
+0 −68		deployments/arbitrum/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −1		deployments/gnosis/.chainId
+0 −1,318		deployments/gnosis/EntryPoint.json
+0 −68		deployments/gnosis/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −1		deployments/goerli/.chainId
+0 −1,318		deployments/goerli/EntryPoint.json
+0 −68		deployments/goerli/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −1		deployments/kovan/.chainId
+0 −1,073		deployments/kovan/EntryPoint.json
+0 −338		deployments/kovan/SimpleWallet.json
+0 −118		deployments/kovan/TestCounter.json
+0 −86		deployments/kovan/solcInputs/9255faacf3ae4e81db1326413027bfa0.json
+0 −1		deployments/mainnet/.chainId
+0 −1,318		deployments/mainnet/EntryPoint.json
+0 −107		deployments/mainnet/SimpleAccountFactory.json
+0 −329		deployments/mainnet/solcInputs/02113a2ed1850c3774563305ee607f11.json
+0 −68		deployments/mainnet/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −59		deployments/mainnet/solcInputs/cfbebdf1101dd2bc0f310cb0b7d62cb7.json
+0 −1		deployments/matic/.chainId
+0 −1,318		deployments/matic/EntryPoint.json
+0 −68		deployments/matic/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −59		deployments/matic/solcInputs/cfbebdf1101dd2bc0f310cb0b7d62cb7.json
+0 −1		deployments/mumbai/.chainId
+0 −1,318		deployments/mumbai/EntryPoint.json
+0 −68		deployments/mumbai/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −1		deployments/optimism/.chainId
+0 −1,318		deployments/optimism/EntryPoint.json
+0 −68		deployments/optimism/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −1		deployments/sepolia/.chainId
+0 −1,318		deployments/sepolia/EntryPoint.json
+0 −68		deployments/sepolia/solcInputs/a4c52f0671aad8941c53d6ead2063803.json
+0 −1,024		erc/ERCS/erc-4337.md
+0 −392		erc/ERCS/erc-7562.md
+0 −1		erc/assets/erc-4337/bundle-seq-pm.svg
+0 −1		erc/assets/erc-4337/bundle-seq.svg
+ −		erc/assets/erc-4337/image1.png
+ −		erc/assets/erc-4337/image2.png
+5 −0		funding.json
+1 −0		.gitattributes
+6 −12		.github/workflows/ci.yml
+3 −1		.github/workflows/sync.yml
+0 −3		.gitmodules
+1 −1		README.md
+3 −3		foundry.toml
+0 −1		lib/ds-test
+1 −1		package.json
+635 −0		scripts/vm.py
+518 −225		src/StdAssertions.sol
+25 −10		src/StdChains.sol
+2 −2		src/StdCheats.sol
+18 −3		src/StdInvariant.sol
+7 −11		src/StdJson.sol
+202 −107		src/StdStorage.sol
+179 −0		src/StdToml.sol
+1 −1		src/StdUtils.sol
+4 −4		src/Test.sol
+1,534 −480		src/Vm.sol
+401 −382		src/console.sol
+1 −1,555		src/console2.sol
+51 −33		src/mocks/MockERC20.sol
+46 −36		src/mocks/MockERC721.sol
+693 −4		src/safeconsole.sol
+39 −909		test/StdAssertions.t.sol
+36 −26		test/StdChains.t.sol
+19 −11		test/StdCheats.t.sol
+3 −1		test/StdError.t.sol
+49 −0		test/StdJson.t.sol
+8 −8		test/StdMath.t.sol
+167 −11		test/StdStorage.t.sol
+49 −0		test/StdToml.t.sol
+20 −20		test/StdUtils.t.sol
+3 −3		test/Vm.t.sol
+8 −0		test/fixtures/test.json
+6 −0		test/fixtures/test.toml
+1 −1		test/mocks/MockERC20.t.sol
+1 −1		test/mocks/MockERC721.t.sol