fix: address compiler warnings (#149)

erc6900 · Aug 21, 2024 · 9d3aad7 · 9d3aad7
1 parent 236a601
commit 9d3aad7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/account/SemiModularAccount.sol b/src/account/SemiModularAccount.sol
@@ -40,15 +40,6 @@ contract SemiModularAccount is UpgradeableModularAccount {
 
     constructor(IEntryPoint anEntryPoint) UpgradeableModularAccount(anEntryPoint) {}
 
-    /// Override reverts on initialization, effectively disabling the initializer.
-    function initializeWithValidation(ValidationConfig, bytes4[] calldata, bytes calldata, bytes[] calldata)
-        external
-        override
-        initializer
-    {
-        revert InitializerDisabled();
-    }
-
     /// @notice Updates the fallback signer address in storage.
     /// @dev This function causes the fallback signer getter to ignore the bytecode signer if it is nonzero. It can
     /// also be used to revert back to the bytecode signer by setting to zero.
@@ -83,6 +74,15 @@ contract SemiModularAccount is UpgradeableModularAccount {
         return _retrieveFallbackSignerUnchecked(_getSemiModularAccountStorage());
     }
 
+    /// Override reverts on initialization, effectively disabling the initializer.
+    function initializeWithValidation(ValidationConfig, bytes4[] calldata, bytes calldata, bytes[] calldata)
+        external
+        pure
+        override
+    {
+        revert InitializerDisabled();
+    }
+
     function _execUserOpValidation(
         ModuleEntity userOpValidationFunction,
         PackedUserOperation memory userOp,

diff --git a/test/account/DirectCallsFromModule.t.sol b/test/account/DirectCallsFromModule.t.sol
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: UNLICENSED
 pragma solidity ^0.8.19;
 
 import {UpgradeableModularAccount} from "../../src/account/UpgradeableModularAccount.sol";