feat: [v0.8-develop] merge plugin manager contracts 2/N #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamegyed
changed the title
fangting-alchemy
approved these changes
Jul 18, 2024
Zer0dot
approved these changes
Jul 19, 2024
adamegyed
force-pushed
the
adam/user-controlled-install
branch
from
9b36599 to
044492f
Compare
adamegyed
force-pushed
the
adam/merge-plugin-manager
branch
from
220497a to
2a5de9d
Compare
adamegyed
force-pushed
the
adam/merge-plugin-manager
branch
from
2a5de9d to
1ba0233
Compare
adamegyed
added a commit
that referenced
this pull request
Jul 26, 2024
adamegyed
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PluginManagerInternalsandPluginManagershare logic, and don't really need to be separated, as they both deal with updates to account state around installing and uninstalling plugins.Solution
Merge the two files.
Update the internal functions
_addValidationFunctionand_removeValidationFunctionto be reused across the two install flows.Fix a naming issue from before – the
ManifestValidationstruct still had a field calledisDefault, which is updated here toisGlobal.