fix: Rename plugin to module #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zer0dot
reviewed
Jul 19, 2024
README.md
Outdated
| @@ -11,7 +11,7 @@ The implementation includes an upgradable modular account with two plugins (`Sin | |||
|
|
|||
| ## Development | |||
|
|
|||
| Anyone is welcome to submit feedback and/or PRs to improve code or add Plugins. | |||
| Anyone is welcome to submit feedback and/or PRs to improve code or add Modules. | |||
There was a problem hiding this comment.
Minor note/todo: we should consider if having modules be on this repo is the way to go, or if we should split them out into another repo (long term)
There was a problem hiding this comment.
Yeah I think we've already started encouraging people to put these in their own repos or in https://github.com/erc6900/sample-plugins, to make the maintenance load easier. The README has some other out-of-date things, too.
There was a problem hiding this comment.
Yeah, gonna remove the add modules part.
adamegyed
approved these changes
Jul 19, 2024
src/interfaces/IStandardExecutor.sol
Outdated
| @@ -12,15 +12,15 @@ struct Call { | |||
|
|
|||
| interface IStandardExecutor { | |||
| /// @notice Standard execute method. | |||
| /// @dev If the target is a plugin, the call SHOULD revert. | |||
| /// @dev If the target is a module, the call SHOULD revert. | |||
There was a problem hiding this comment.
Todo for later: remove this line
src/account/AccountStorage.sol
Outdated
| @@ -43,11 +43,11 @@ struct AccountStorage { | |||
| // AccountStorageInitializable variables | |||
| uint8 initialized; | |||
| bool initializing; | |||
| // Plugin metadata storage | |||
| EnumerableMap.AddressToUintMap pluginManifestHashes; | |||
| // Module metadata storage | |||
There was a problem hiding this comment.
This line is outdated, todo: update
adamegyed
pushed a commit
that referenced
this pull request
Jul 26, 2024
adamegyed
pushed a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename plugin to module as discussed.