fix: Handle fallback hooks & entrypoint/self-call/public selector runtime execution hooks #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-call, public selectors and entrypoint calls
adamegyed
approved these changes
Jul 25, 2024
adamegyed
pushed a commit
that referenced
this pull request
Jul 26, 2024
…time execution hooks (#112)
adamegyed
pushed a commit
that referenced
this pull request
Aug 5, 2024
…time execution hooks (#112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses an issue flagged by @0xrubes where execution hooks would be run twice in the case of an allowed caller calling into a fallback function.
It also addresses an issue where execution hooks would be skipped when the caller is the account or the entrypoint, or when the called selector is public.
Solution
We now correctly handle the return values from
_checkPermittedCallerAndAssociatedHooks()in the fallback function, and we now run the execution hooks in the latter function regardless of who the caller is or if the selector is public.Note that permission hooks are only run when a validation function (
executeWithAuthorization()) or direct-call validation is used.