Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Solady instead of Openzeppelin for Factory #118

Closed
wants to merge 3 commits into from

Conversation

Zer0dot
Copy link
Contributor

@Zer0dot Zer0dot commented Jul 26, 2024

Motivation

Openzeppelin's ERC1967 proxy contract includes some redundancies due to Solidity's compilation, it's generally more efficient to use Solady's implementations.

Solution

Replace the ERC1967 creation with LibClone calls, and OZ's Ownable with Solady's equivalent.

@Zer0dot Zer0dot closed this Jul 26, 2024
@Zer0dot
Copy link
Contributor Author

Zer0dot commented Jul 26, 2024

Closed as OZ is more well-documented, and gas is not a priority for the RI.

@Zer0dot Zer0dot deleted the zer0dot/optimize-factory branch July 26, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant