Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single signer validation duplicate view func, missing 1271 UO validation #124

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

adamegyed
Copy link
Contributor

Motivation

  • SingleSignerValidation had two view functions that did the same thing - signer and signerOf.
  • Missing 1271 owner validation check in validateUserOp

Solution

  • Remove signerOf and rename the public storage field signer -> signers
    • Seems like generally the style we've been doing so far, but open to switching back
  • Use the same SignatureChecker lib used for validateSignature in validateUserOp

@adamegyed adamegyed requested a review from a team August 1, 2024 17:24
Copy link
Contributor

@Zer0dot Zer0dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nice catch with the missing 1271 UO validation!

@adamegyed adamegyed force-pushed the adam/single-signer-fixes branch from bbad301 to ac89ec7 Compare August 1, 2024 21:51
@adamegyed adamegyed merged commit 16b654b into develop Aug 1, 2024
3 checks passed
@adamegyed adamegyed deleted the adam/single-signer-fixes branch August 1, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants