Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update install execution events #125

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

adamegyed
Copy link
Contributor

Motivation

With the user-controlled manifests introduced in #101, the existing ModuleInstalled events no longer sufficiently describe what happens during an install or uninstall.

Additionally, it is likely unnecessary to index the callback success field in the events.

Solution

@adamegyed adamegyed requested a review from a team August 1, 2024 18:04
Copy link
Contributor

@Zer0dot Zer0dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, another good catch-- looks good to me, nice and simple.

@adamegyed adamegyed force-pushed the adam/install-execution-events branch from 0636473 to 721819e Compare August 1, 2024 21:57
@adamegyed adamegyed force-pushed the adam/install-execution-events branch from 721819e to fe41301 Compare August 1, 2024 22:10
@adamegyed adamegyed merged commit f9b20ad into develop Aug 1, 2024
3 checks passed
@adamegyed adamegyed deleted the adam/install-execution-events branch August 1, 2024 22:33
adamegyed added a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants