feat: add allowlist deploy script & fix existing deploy script [2/2] #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamegyed
force-pushed
the
adam/allowlist-deploy
branch
from
68a95cc to
99d5a55
Compare
| uint256 stakeToAdd = stakeAmount - currentStake; | ||
|
|
||
| if (stakeToAdd > 0) { | ||
| console2.log("Adding stake: ", stakeToAdd); | ||
| entryPoint.addStake{value: stakeToAdd}(unstakeDelay); |
There was a problem hiding this comment.
haha this comment made me realize a mistake - we should use the value stakeToAdd, not stakeAmount
fangting-alchemy
approved these changes
Aug 1, 2024
|
Look good. Need to fix tests |
adamegyed
force-pushed
the
adam/allowlist-deploy
branch
from
99d5a55 to
4dc064e
Compare
adamegyed
force-pushed
the
adam/allowlist-update
branch
from
5aa0d70 to
d3922e2
Compare
adamegyed
force-pushed
the
adam/allowlist-deploy
branch
2 times, most recently
from
afc6423 to
6ddbf5b
Compare
adamegyed
force-pushed
the
adam/allowlist-update
branch
from
0886e60 to
ce25904
Compare
adamegyed
force-pushed
the
adam/allowlist-deploy
branch
from
6ddbf5b to
9a49d23
Compare
adamegyed
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To test the use of permission-limiting hooks, we should deploy AllowlistModule. To do that, we need a deploy script.
Also I found some issues in the existing script + factory setup, so fixing those here, too.
Solution
Deploy.s.solwhere the sender was staking with the EntryPoint, instead of the factory.Deploy.s.t.sol.Deploy.s.solfromconsole2toconsole- there's no difference anymore.AccountFactoryto take in the unstake delay from the owner's call, rather than specifying this as an immutable.