-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] refactor/SMA: Inheritable Account Refactor #133
Merged
Zer0dot
merged 15 commits into
zer0dot/sma-fallback-bytecode-signer
from
zer0dot/inheritable-account
Aug 12, 2024
Merged
[DRAFT] refactor/SMA: Inheritable Account Refactor #133
Zer0dot
merged 15 commits into
zer0dot/sma-fallback-bytecode-signer
from
zer0dot/inheritable-account
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zer0dot
changed the title
Zer0dot/inheritable account
[DRAFT] refactor/SMA: Inheritable Account Refactor
Aug 7, 2024
Zer0dot
force-pushed
the
zer0dot/sma-fallback-bytecode-signer
branch
from
August 7, 2024 18:14
5d739e9
to
11c90e5
Compare
Zer0dot
force-pushed
the
zer0dot/inheritable-account
branch
3 times, most recently
from
August 7, 2024 18:30
45cce9b
to
fdd8baf
Compare
Zer0dot
force-pushed
the
zer0dot/inheritable-account
branch
from
August 7, 2024 19:51
fdd8baf
to
d5290d6
Compare
Zer0dot
merged commit Aug 12, 2024
e5f881a
into
zer0dot/sma-fallback-bytecode-signer
3 checks passed
Zer0dot
added a commit
that referenced
this pull request
Aug 12, 2024
Zer0dot
added a commit
that referenced
this pull request
Aug 15, 2024
Zer0dot
added a commit
that referenced
this pull request
Aug 16, 2024
Zer0dot
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces a refactor that adds overridable functions to validation calls to make SMAs easier to develop, review, and audit, as well as to isolate the core contract from SMAs.
This way, creating an SMA with custom validation logic is as simple as inheriting from the parent modular account.
Solution
Add internal virtual functions wrapping validation module calls. These can then be overriden in an inheriting contract to implement custom validation logic, as is done with an SMA here.
This also involved a test refactor to leverage the same test suite for both the inheriting and original accounts. This uses a new environment boolean variable "SMA_TEST," which is true if the test suite should be run for the SMA.
This variable is then read in certain places where logic that is different between SMAs and the parent modular account is needed. Mainly, initializing with a validation, creating an account, or affecting the single signer validation (which is built-in for the SMA).
TODO