-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: module suffix to execution and validation interfaces #134
refactor: module suffix to execution and validation interfaces #134
Conversation
088d4f3
to
7fb76b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure this is a net improvement. It helps in the concrete type naming (i.e. SingleSignerValidationModule) where it lines up with some other naming schemes (like AllowlistModule), but in the cases of the interfaces, it makes it really wordy.
Also flagged some instances where I think the added "address" wording is unnecessary.
I'm not sure it helps comprehension, but obviously this is coming from a very familiar perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's pass this by the rest of the working group - I think it's a helpful change but if I'm the minority, happy to find alternatives or keep things as is!
7fb76b7
to
3bcaa2d
Compare
Some things to also look at: The events reference-implementation/src/interfaces/IModuleManager.sol Lines 13 to 16 in ed9258e
And other places where we reference "validation functions" as
In this PR, we separate the concept of a "validation module" and a "validation function" from both being under the umbrella term of "validation", which I think is a good thing. |
Open to pushback on this. I personally think this makes things clearer in understanding that all of these things are modules, and unifies file/contract naming across our module types.