refactor: merge segment collection logic [1/2] #143
Merged
+120
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamegyed
changed the title
adamegyed
force-pushed
the
adam/merge-segment-logic
branch
from
13beea1 to
2168a96
Compare
jaypaik
approved these changes
Aug 16, 2024
adamegyed
force-pushed
the
adam/merge-segment-logic
branch
from
2168a96 to
d042a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have duplicate code for advancing signature segments in runtime and user op validation.
Additionally, there was one more failure case for the final segment - length that exceeds the final segment.
Solution
Merge duplicate logic into
SparseCalldataSegmentLib.Add a check for the extra data past-the-end of the signature, and tests that verify this behavior.