feat: add signature validation hooks [2/2] #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamegyed
force-pushed
the
adam/merge-segment-logic
branch
from
13beea1 to
2168a96
Compare
adamegyed
force-pushed
the
adam/add-signature-validation-hooks
branch
from
450cf0c to
0e510c6
Compare
jaypaik
reviewed
Aug 16, 2024
adamegyed
force-pushed
the
adam/add-signature-validation-hooks
branch
from
0e510c6 to
9469bc6
Compare
jaypaik
approved these changes
Aug 20, 2024
| if (!_storage.validationData[sigValidation].isSignatureValidation) { | ||
| revert SignatureValidationInvalid(module, entityId); | ||
| (address _module, uint32 _entityId) = sigValidation.unpack(); |
There was a problem hiding this comment.
At some point would love to revisit all of our variable naming according to our style guide.
There was a problem hiding this comment.
Yep, we should pick a standardized way to name vars when avoiding shadowing. RIght now, this pattern is ambiguous with internal-visibility variables and constants.
adamegyed
force-pushed
the
adam/merge-segment-logic
branch
from
2168a96 to
d042a7d
Compare
adamegyed
force-pushed
the
adam/add-signature-validation-hooks
branch
from
9469bc6 to
19118e0
Compare
adamegyed
force-pushed
the
adam/add-signature-validation-hooks
branch
from
19118e0 to
496af4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have had a stub pre validation hook type for 1271 signatures for a while, but never implemented it.
Solution
Define the interface and implement the logic for calling these hooks in the base account.
Add test cases for using the hooks, and sending per-hook data.
Also removes old todo comments about the interface functions.