Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge account interfaces #148

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

adamegyed
Copy link
Contributor

@adamegyed adamegyed commented Aug 19, 2024

Motivation

We currently have three interfaces for modular accounts: IStandardExecutor (required), IAccountLoupe (optional), and IModuleManager (required).

We've discussed the idea of merging them, and possibly making IAccountLoupe mandatory.

Solution

Merge IStandardExecutor and IModuleManager into a new interface IModularAccount.

To discuss

This draft PR shows what it would look like to merge all three of these interfaces into one IModularAccount. It is, unfortunately, rather verbose in a single file. We could opt to keep one of them split out, like IModuleManager or IAccountLoupe, but unclear which one should be omitted, if at all. Putting this PR up to open discussion about the desired interface.

@0xrubes
Copy link

0xrubes commented Aug 20, 2024

It is really just a gut feeling, but how about combining IExecutor and IModuleManager to IModularAccount and keeping IAccountLoupe separate?
Mandatory loupe would probably make things more easy for dApps and offchain stuff I assume?

@adamegyed
Copy link
Contributor Author

adamegyed commented Aug 20, 2024

Makes sense, we can keep IAccountLoupe separate and optional, and merge the other two. Updating PR...

@adamegyed adamegyed force-pushed the adam/merge-account-interfaces branch 3 times, most recently from 95e4f2f to 6a34be3 Compare August 20, 2024 22:38
@adamegyed adamegyed changed the base branch from adam/add-interface-checks to develop August 20, 2024 22:42
@adamegyed adamegyed force-pushed the adam/merge-account-interfaces branch from 6a34be3 to bdf07c5 Compare August 20, 2024 22:46
@adamegyed adamegyed marked this pull request as ready for review August 20, 2024 22:48
@adamegyed adamegyed requested a review from a team August 20, 2024 22:48
@adamegyed adamegyed changed the title [draft] feat: merge account interfaces feat: merge account interfaces Aug 20, 2024
@adamegyed adamegyed force-pushed the adam/merge-account-interfaces branch from bdf07c5 to 3397ef8 Compare August 21, 2024 22:29
@adamegyed adamegyed merged commit 78bc489 into develop Aug 21, 2024
3 checks passed
@adamegyed adamegyed deleted the adam/merge-account-interfaces branch August 21, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants