Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently have three interfaces for modular accounts:
IStandardExecutor
(required),IAccountLoupe
(optional), andIModuleManager
(required).We've discussed the idea of merging them, and possibly making
IAccountLoupe
mandatory.Solution
Merge
IStandardExecutor
andIModuleManager
into a new interfaceIModularAccount
.To discuss
This draft PR shows what it would look like to merge all three of these interfaces into oneIModularAccount
. It is, unfortunately, rather verbose in a single file. We could opt to keep one of them split out, likeIModuleManager
orIAccountLoupe
, but unclear which one should be omitted, if at all. Putting this PR up to open discussion about the desired interface.