Remove extraneous install/uninstall field checking #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
force-pushed
the
ft_update
branch
from
2ee5992 to
2c8a124
Compare
src/account/AccountLoupe.sol
Outdated
| @@ -15,14 +15,12 @@ import { | |||
| } from "../libraries/AccountStorage.sol"; | |||
| import {FunctionReference} from "../libraries/FunctionReferenceLib.sol"; | |||
|
|
|||
| abstract contract BaseModularAccountLoupe is IPluginLoupe { | |||
| abstract contract AccountLoupe is IAccountLoupe { | |||
There was a problem hiding this comment.
You probably need to cherry pick this commit out.
There was a problem hiding this comment.
Fixed, I think it changed commits when #13 was force-pushed
adam-alchemy
force-pushed
the
adam/install-validity
branch
from
6481286 to
0e95e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a large amount of extraneous checks in plugin installation and uninstallation that are not required by the ERC-6900 standard.
Solution
uninstallPluginthat assert the values to be the same as what was used during installation. Because the manifest hash is validated prior to the individual field removals, we know that all fields must have been successfully added.permittedExecutionSelectorsmust be installed. Due to the possibility that other hooks may cause the call toexecuteFromPluginto fail, plugins must already expect this possibility, and a lack of installation results in a similar call revert.This PR is stacked on top of #13, and should only be merged after the underlying is merged.