Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update accountId and moduleId to use period delimiters #162

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Aug 26, 2024

For 7579 alignment. Follow-up to #152 and #153 .

@jaypaik jaypaik requested review from a team and 0xrubes August 26, 2024 20:28
@jaypaik jaypaik force-pushed the 08-26-feat_update_accountId_and_moduleId_to_use_period_delimiters branch from f9660c7 to 96fc9d5 Compare August 26, 2024 20:28
@jaypaik jaypaik merged commit e2211d1 into develop Aug 26, 2024
3 checks passed
Copy link

@0xrubes 0xrubes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@jaypaik jaypaik deleted the 08-26-feat_update_accountId_and_moduleId_to_use_period_delimiters branch October 9, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants