Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deferred installation wording to validation installation #165

Merged
merged 1 commit into from
Aug 27, 2024
Merged

feat: add deferred installation wording to validation installation #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions standard/ERCs/erc-6900.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,10 @@ TODO for v0.8

#### Validations and their installation /uninstallation

An account can have more than one validation installed.
An account can have more than one validation module/function installed.
An account can have the same validation module installed more than once.
The entityId of a validation installed on an account MUST be unique.
The entityId of a validation function installed on an account MUST be unique.
Validation installation MAY be deferred until a later time, such as upon first use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation installation MAY be deferred until a later time, such as upon first use.

Not sure if this is the place to put this callout. I know we haven't yet updated the section for the install / uninstall functions, but it seems like this should be mentioned there instead, like "these functions are not the only way to install a module, the account MAY define other functions for installing and uninstalling modules".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this section (#### Validations and their installation /uninstallation) is aiming for more general (un)installations callout like this.

"these functions are not the only way to install a module, the account MAY define other functions for installing and uninstalling modules".
Should we callout this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, it is just an overview. Approving to unblock.


#### Responsibilties of `StandardExecutor` and `ModuleExecutor`

Expand Down
Loading