Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR was created to resolve the 2 potential points in the code.
validationData.isUserOpValidation
not getting properly uninitialized during uninstallation.Here:
reference-implementation/src/account/ModuleManagerInternals.sol
Line 102 in 38231a3
and here:
reference-implementation/src/account/ModuleManagerInternals.sol
Line 322 in 38231a3
Solution
isUserOpValidation
variable to false during uninstallation.