Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Module Manager #178

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

PowerStream3604
Copy link
Contributor

@PowerStream3604 PowerStream3604 commented Aug 31, 2024

Motivation

This PR was created to resolve the 2 potential points in the code.

  1. validationData.isUserOpValidation not getting properly uninitialized during uninstallation.
  2. Redundant selector clearing code during uninstallation of Validation.

Solution

  1. Added logic to change the value of isUserOpValidation variable to false during uninstallation.
  2. Removed redundant code.

@PowerStream3604 PowerStream3604 force-pushed the PowerStream3604/optimize-module-manager branch from 510aad0 to ad7fefc Compare August 31, 2024 14:52
@PowerStream3604 PowerStream3604 force-pushed the PowerStream3604/optimize-module-manager branch from ad7fefc to 89be871 Compare August 31, 2024 14:53
@PowerStream3604 PowerStream3604 requested a review from a team August 31, 2024 15:05
Copy link
Contributor

@adamegyed adamegyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for finding this!

@PowerStream3604 PowerStream3604 merged commit feb8c01 into develop Sep 3, 2024
3 checks passed
@PowerStream3604 PowerStream3604 deleted the PowerStream3604/optimize-module-manager branch September 3, 2024 15:37
jaypaik added a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants